Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 super gets removed in derived anonymous class (parse/noSuperWithoutExtends) #2108

Closed
1 task done
FCQCarryOut opened this issue Mar 15, 2024 · 1 comment · Fixed by #2113
Closed
1 task done

🐛 super gets removed in derived anonymous class (parse/noSuperWithoutExtends) #2108

FCQCarryOut opened this issue Mar 15, 2024 · 1 comment · Fixed by #2113
Assignees
@Sec-ant
Labels
A-Analyzer Area: analyzer L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug

Comments

@FCQCarryOut
Copy link

Environment information

should not be required for this issue.
Issue is reproducible in playground.

What happened?

super() gets removed / marked as invalid

Error: Super() is only valid in derived class constructors

https://biomejs.dev/playground/?code=YwBsAGEAcwBzACAATwB0AGgAZQByACAAewAKACAAIAAgACAAYwBvAG4AcwB0AHIAdQBjAHQAbwByACgAKQAgAHsACgAgACAAIAAgACAAIAAgACAAYwBvAG4AcwBvAGwAZQAuAGwAbwBnACgAIgAiACkACgAgACAAIAAgAH0ACgB9AAoACgBjAGwAYQBzAHMAIABFAHgAYQBtAHAAbABlACAAewAKACAAIAAgACAAdABlAHMAdAAoACkAIAB7AAoAIAAgACAAIAAgACAAIAAgAHIAZQB0AHUAcgBuACAAbgBlAHcAIABjAGwAYQBzAHMAIABlAHgAdABlAG4AZABzACAATwB0AGgAZQByACAAewAKAAoAIAAgACAAIAAgACAAIAAgACAAIAAgACAAcAByAGkAdgBhAHQAZQAgAG8AdABoAGUAcgA6ACAAbgB1AG0AYgBlAHIAOwAKAAoAIAAgACAAIAAgACAAIAAgACAAIAAgACAAYwBvAG4AcwB0AHIAdQBjAHQAbwByACgAKQAgAHsACgAgACAAIAAgACAAIAAgACAAIAAgACAAIAAgACAAIAAgAHMAdQBwAGUAcgAoACkAOwAKAAoAIAAgACAAIAAgACAAIAAgACAAIAAgACAAIAAgACAAIAB0AGgAaQBzAC4AbwB0AGgAZQByACAAPQAgADEAMAA7AAoAIAAgACAAIAAgACAAIAAgACAAIAAgACAAfQAKACAAIAAgACAAIAAgACAAIAB9ACgAKQA7AAoAIAAgACAAIAB9AAoAfQAKAA%3D%3D

Expected result

super should be allowed in derived anonymous class.

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@Sec-ant
Copy link
Member

Sec-ant commented Mar 16, 2024

I'd like to work on this.

@ematipico ematipico added S-Bug-confirmed Status: report has been confirmed as a valid bug A-Analyzer Area: analyzer L-JavaScript Language: JavaScript and super languages labels Mar 16, 2024
@Sec-ant Sec-ant mentioned this issue Mar 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sec-ant Sec-ant

Labels
A-Analyzer Area: analyzer L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(noSuperWithoutExtends): detect class expressions Sec-ant/biome
3 participants
@ematipico @Sec-ant @FCQCarryOut