fix(lint/noBlankTarget): don't hang when applying the code fix #2687
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #2675
The code fix created a JSX string with a
JSX_IDENT
token.inner_string_text
is called to retrieve the content of the attribute.inner_string_text
removes quotes only when the token is aJSX_STRING_LITERAL
.Thus, on first run, the quotes were well removed, while on the following run, the quotes are not removed.
This led to a never fixed lint rule and thus, an infinite loop.
I also fixed a similar issue for
noUselessFragments
which was not observed yet.To avoid this kind of issue we could:
debug_assert
in node factories (this should be generated by the grammar) to guarantee that every leaf node has the correct token kind.We should ensure that this doesn't lead to an infinite loop.
Test Plan
I manually tested the code.
We could add a test in
biome_cli
however I think it is not worth it because this could require to add a test for every rule that create jsx/js/css strings.