Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(biome_diagnostics): fix JetBrains relative file URLs should be clickable when given line and column numbers #4876

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

Andrew-Chen-Wang
Copy link

Summary

Fixes #4874

Jetbrains IDEs for relative file paths aren't clickable in diagnostics output. In webstorm, it requires prepending at (notice the whitespaces)

This does not fix the case where no line numbers and column numbers are displayed for relative paths. See test cases

Test Plan

The environment variable can be found here:

Screenshot 2025-01-11 at 7 55 24 AM

Test cases display:

  • the environment variable
  • a test where my relative path in my app was caught with a lint error but nothing was highlighted
  • this PR only resolves relative file paths with column numbers and/or line numbers
  • separate variant with only a line number
  • test case that the absolute path case does work, regardless if there's a line number or not
Screenshot 2025-01-11 at 7 57 24 AM - This is in PyCharm. Some devs develop across IDEs, and here it does work

@ematipico
Copy link
Member

Sorry, I wasn't clear enough. The link should be in the code, as a comment.

The PR gets lost, but the code stays :)

@Andrew-Chen-Wang
Copy link
Author

updated @ematipico thanks for the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Diagnostic Area: diagnostocis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants