Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💅 useSimpleNumberKeys doesn't ignore comments #918

Closed
1 task done
yphoenix opened this issue Nov 27, 2023 · 1 comment · Fixed by #957
Closed
1 task done

💅 useSimpleNumberKeys doesn't ignore comments #918

yphoenix opened this issue Nov 27, 2023 · 1 comment · Fixed by #957
Assignees
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug

Comments

@yphoenix
Copy link

Environment information

CLI:
  Version:                      1.4.0
  Color support:                true

Platform:
  CPU Architecture:             aarch64
  OS:                           macos

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v21.2.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         unset

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 true

Workspace:
  Open Documents:               0

Rule name

lint/complexity/useSimpleNumberKeys

Playground link

https://biomejs.dev/playground/?code=YwBvAG4AcwB0ACAATQB5AE8AYgBqACAAPQAgAHsACgAJAC8ALwAgAEMAbwBtAG0AZQBuAHQACgAJADQAMgA6ACAAewAKAAkAfQAKAH0ACgA%3D

Expected result

Should ignore the comments and not flag a lint error.

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@Conaclos Conaclos added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug labels Nov 27, 2023
@yphoenix yphoenix changed the title lint/complexity/useSimpleNumberKeys doesn't ignore comments💅 <TITLE> 💅 useSimpleNumberKeys doesn't ignore comments Nov 27, 2023
@kalleep
Copy link
Contributor

kalleep commented Nov 29, 2023

Hey 👋 I would like to give this a try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants