-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: autodiscover ESM and CJS configuration files #64
Conversation
Haven't had time to look at this yet, but ...
On the face of it, I'd expect that to be the behaviour 🤔 Any particular reason you didn't implement it? If not, please feel free to add it 🙂 |
Added. Note that this implementation requires the configuration file to be placed at the same level than the package.json when loading |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this looks great! Nice work @mondeja
Most of my comments are rather specific but straightforward requests. A couple topics might spark a discussion.
🎉 This PR is included in version 2.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR implements the autodiscovering of
.svglintrc.cjs
and.svglintrc.mjs
files. The logic is simple:--config
CLI argument, it will be loaded or exits with code 1.svglintrc.js
exists in the current working directory, load itpackage.json
file withtype="module"
and a.svglintrc.cjs
file exists, load it.svglintrc.mjs
file, load itI've not included the autodiscovering of.svglintrc.cjs
and.svglintrc.mjs
files for parent directories, let me know if it would be the desired behaviour.