Fail throwing Error from custom rule #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birjj
suggested changes
Nov 20, 2020
There was a problem hiding this comment.
Thanks for the quick PR!
I think using the error state is the right call. This means that the exception itself will be displayed as an exception (using the !!! prefix), while the file will be marked as errored. It's been a while since I've worked with svglint though, so it'd probably be best to manually test that this is the case.
I'm happy to merge and release after some minor changes:
|
Changes done! 👍 |
birjj
approved these changes
Nov 20, 2020
|
👍 Thanks! I've quickly manually tested, and everything seems to be in order. I'll get this released asap. |
|
🎉 This PR is included in version 1.0.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20
If you throw an
Errorfrom a custom rule is not reported, failing silently. I have used theerrorstate in the absence of anexceptionstate, but I'm not that familiar with the implementation as to define a new state because I'm not sure of the implications.