Disable '-Djdk.module.illegalAccess=deny' javaoption

Disable the java option because it causes issues in the resulting app if packaged with a recent Java Runtime (tested with Java 11, 14 and 15).
bisq-network · Oct 8, 2020 · 696a788 · 696a788
1 parent 0b40dff
commit 696a788
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/desktop/package/package.gradle b/desktop/package/package.gradle
@@ -222,15 +222,20 @@ task packageInstallers {
                 " --copyright \"© 2020 Bisq\"" +
                 " --vendor Bisq" +
                 " --temp \"${jpackateTempDir}\"" +
+
                 // Options for creating the application image
                 " --input ${fatJarFolderPath}" +
+
                 // Options for creating the application launcher
                 " --main-jar ${mainJarName}" +
                 " --main-class bisq.desktop.app.BisqAppMain" +
                 " --java-options -Xss1280k" +
                 " --java-options -XX:MaxRAM=4g" +
                 " --java-options -Djava.net.preferIPv4Stack=true" +
-                " --java-options -Djdk.module.illegalAccess=deny" +
+                // Warning: this will cause guice reflection exceptions and lead to issues with the guice internal cache
+                // resulting in the UI not loading
+//              " --java-options -Djdk.module.illegalAccess=deny" +
+
                 // Options for creating the application package
                 " --license-file \"${licenseFilePath}\"" +
                 " --runtime-image \"${jdkForAppRuntimePath}\""