Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAO: Add a pop up asking users to wait for the proposal confirmation #2367

Closed
arunasurya opened this issue Feb 4, 2019 · 4 comments
Closed
Assignees
Milestone

Comments

@arunasurya
Copy link
Contributor

I noticed that there is a delay of 10-15 sec between making a proposal and getting its confirmation in DAO on testnet. It is not clear if a user should wait or go ahead and do something else.

Suggestion: add a pop-up window that says something like "Please wait for the confirmation of your proposal" while the proposal transaction is being confirmed.

@ManfredKarrer
Copy link
Contributor

That seems to be from the timeout at tx publishing. Just saw it myself.... So yes we should keep a spinner until the result is present.

@ripcurlx
Copy link
Contributor

ripcurlx commented Feb 6, 2019

@ManfredKarrer It was reset atm by you by intent.

// We reset UI without waiting for callback as callback might be slow and then the user could create multiple
// proposals.
if (proposalDisplay != null)
proposalDisplay.clearForm();
proposalTypeComboBox.getSelectionModel().clearSelection();

I could add a spinner and lock the form until it is published. Maybe the use case that people want to create quickly multiple proposals at the same time is mainly in testing right now, but makes it less user friendly in a real life scenario.

@ManfredKarrer
Copy link
Contributor

yes the button should be deactivated so the user cannot create multiple same proposals (as mats did in one cycle).

@ripcurlx
Copy link
Contributor

ripcurlx commented Feb 7, 2019

I changed the layout like that:
bildschirmfoto 2019-02-07 um 10 03 58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants