-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove / refactor BSFormatter (tracking issue) #3240
Comments
If you do think this should be taken care of please review the first (trivial) PR #3239. |
Reposting the design principles that led me to this refactoring:
I assume these are not contentious and am omitting justification. Happy to discuss these points if there is dissent. |
Here is step 2. Extract 2 classes #3244 |
This was referenced Sep 11, 2019
Completed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While making myself familiar with the code and thinking about improvements I kept seeing complexities connected to the BSFormatter class.
The code base is quite tangled up and that class is one of the places that contributes because:
This led me to refactor it out of existence. The final state of the code is here but it is too much to review and merge in 1 step.
To get the code changes in I can break it down into 5-6 trivial commits / PRs, but don't want to do this work unless other ppl agree that removing this class makes sense.
Please give 👍 or 👎 as feedback on wether I should go ahead. Perhaps I am the only one who has seen these issues, or they aren't hurting anyone and the code can stay as is. In that case I don't want to make the effort.
The text was updated successfully, but these errors were encountered: