Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

National bank transfer doesnt have account number validation #3459

Closed
beingindot opened this issue Oct 24, 2019 · 3 comments · Fixed by #3573
Closed

National bank transfer doesnt have account number validation #3459

beingindot opened this issue Oct 24, 2019 · 3 comments · Fixed by #3573
Labels
good first issue in:payment-methods

Comments

@beingindot
Copy link
Contributor

Description

National bank transfer doesnt have account number validation

Version

1.2.0

Steps to reproduce

create national bank transfer account
select asia and any country
create new account without filling account number.

Expected behaviour

Atleast account number field validation should be there.

Actual behaviour

Able to create new account without filling account number.

Screenshots

Screenshot from 2019-10-24 22-10-38

Device or machine

Ubuntu

Additional info
@ripcurlx
Copy link
Contributor

I think it is tricky to implement this properly for all countries all over the world. We do have special cases for some countries already (e.g. Argentina), but I think doing it properly for all countries is not
feasible right now.

@beingindot
Copy link
Contributor Author

I agree. but i thought we should have account number fileld should not be empty validation.
thats why created this bug.
if that's not enforceable pls close this bug.

@beingindot
Copy link
Contributor Author

working on it.

beingindot added a commit to beingindot/bisq that referenced this issue Nov 7, 2019
@beingindot
Added check for empty validation
31645f5 
This commit is for github issue bisq-network#3458 and bisq-network#3459
check added for moneybeam and national bank transfer
This was referenced Nov 7, 2019
Merged
Closed
beingindot added a commit to beingindot/bisq that referenced this issue Nov 12, 2019
@beingindot
Added check for empty validation
133d40a 
This commit is for github issue bisq-network#3458 and bisq-network#3459
check added for moneybeam and national bank transfer
beingindot added a commit to beingindot/bisq that referenced this issue Nov 13, 2019
@beingindot
Added check for empty validation
755ca19 
This commit is for github issue bisq-network#3458 and bisq-network#3459
check added for moneybeam and national bank transfer
@beingindot beingindot mentioned this issue Dec 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue in:payment-methods
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added check for empty validation beingindot/bisq
3 participants
@ripcurlx @freimair @beingindot