Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revolut account should use revolut username #4155

Closed
eboukamza opened this issue Apr 9, 2020 · 9 comments
Closed

Revolut account should use revolut username #4155

eboukamza opened this issue Apr 9, 2020 · 9 comments

Comments

@eboukamza
Copy link
Contributor

eboukamza commented Apr 9, 2020

Description

User has three ways for sending funds in revolut:

  • username (@revolut_username)
  • phone number / email
  • IBAN

Actually funds are sent by phone number but seller has no way to check the phone number of the buyer into revolut app. To be compliant with Trader Rules (verify trade contract information before confirm the payment) seller should add phone number in their contact list and then compare this username with the username of the payment.

Version

1.3.1

Steps to reproduce

Trade with revolut

Expected behaviour

Revolut accounts in Bisq should use revolut usernames. It is also more private than a phone number.

Actual behaviour

Actually phone number is used for revolut trades

Screenshots

Additional info

Related: #3728 #3777 #1312

@boring-cyborg
Copy link

boring-cyborg bot commented Apr 9, 2020

Thanks for opening your first issue here!

Be sure to follow the issue template. Your issue will be reviewed by a maintainer and labeled for further action.

@eboukamza eboukamza changed the title Revolut account should be revolut username Revolut account should be use revolut username Apr 9, 2020
@eboukamza eboukamza changed the title Revolut account should be use revolut username Revolut account should use revolut username Apr 9, 2020
@Bisq-knight
Copy link

The username feature is gradually being rolled out to revolut users. I know people who don't have it yet.

We should look into it when it's in general availability and the editing feature is there

@ivopashov
Copy link

It can be both username and phone with one of them being mandatory. Username is much more convenient when there.

@pingiun
Copy link
Contributor

pingiun commented Jul 30, 2020

I believe usernames now are generally available. They are much better than phone numbers for privacy reasons, I think the UI should be changed so people can enter their handle instead of phone number. I think this will also solve the issue of Revolut giving payment links when a new phone number is entered.

@svrnhdl
Copy link

svrnhdl commented Aug 29, 2020

How is this going? I was added to a WhatsApp group with 'Bisq Sellers' recently and it spooked me.

Will there be an option to change to username and keep the account signing?

@crowphale
Copy link

I did a couple of transactions through Revolut and always ended up asking for username since Revolut wouldn't send to phone number (even after adding it to Contacts, which is not something people should need to do since often that's synced somewhere in the cloud).

So +1 for this change. If anyone has pointers on how to start on this, I'm happy to help.

@ripcurlx
Copy link
Contributor

ripcurlx commented Sep 3, 2020

This change will be shipped with v1.3.8.

@stale
Copy link

stale bot commented Dec 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the was:dropped label Dec 4, 2020
@ripcurlx
Copy link
Contributor

ripcurlx commented Dec 9, 2020

Closing as complete.

@ripcurlx ripcurlx closed this as completed Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants