fix build on jdk11 and jdk12. remove powermock and jmockit #3081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignore 2 or 3 tests that are not possible to convert now
blabno
suggested changes
Aug 14, 2019
| @Before | ||
| public void setup() throws IOException { | ||
|
|
||
| tsm = mock(TradeStatisticsManager.class); |
There was a problem hiding this comment.
yeah that's what it was called before, will change.
Merged
| @@ -51,7 +51,7 @@ | |||
| @EqualsAndHashCode | |||
| @Getter | |||
| @Slf4j | |||
| public final class OfferPayload implements ProtectedStoragePayload, ExpirablePayload, RequiresOwnerIsOnlinePayload { | |||
| public class OfferPayload implements ProtectedStoragePayload, ExpirablePayload, RequiresOwnerIsOnlinePayload { | |||
There was a problem hiding this comment.
Should stay final for security reasons
There was a problem hiding this comment.
it is final (not in this commit but later)
There was a problem hiding this comment.
Ah saw it now... thanks.
|
|
||
| import org.bitcoinj.core.Coin; | ||
|
|
||
| public class MakerFeeMaker { |
There was a problem hiding this comment.
MakerFeeMaker sounds a bit weird. Maybe MakerFeeProvider?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on jdk 12 the app still throws a NPE at startup (but afterwards it seems to work), but runs fine on jdk11.
build and test suite works on jdk10,11,12, inside IDEA or with
./gradlew clean buildjdk 10 is probably still needed for binaries. but contributors can now use any jdk 10+ that they like
had to disable a very small amount of tests (i think 3) that were not so easy to convert.