Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1.1.6 for seednodes #3261

Merged

Conversation

ripcurlx
Copy link
Contributor

Update seednode branch with release v1.1.6

christophsturm and others added 30 commits August 13, 2019 20:38
Co-Authored-By: Florian Reimair <[email protected]>
The rationale for the "delete fileTree" hack no longer exists
because the conflicting files are not created anymore.
…work#3075

When exporting to CSV, both portfolio/trades and funds/transactions
were lacking the column headers.

Additionally, portfolio/trades colum values were outdated and
not matching the intended export.

Both issues are fixed.
Feature jdk10 instructions more prominently
…mock

fix build on jdk11 and jdk12. remove powermock and jmockit
…mn-headers-in-csv-export

Render proper column headers and values for CSV exports; fix bisq-network#3075
Add wiz bitcoin node to BtcNodes list
…alldist-remove-useless-deletions

Remove legacy hack from build.gradle installDist task
Define missing dependency version variables
Migrate the last coin (Noir) and remove the no longer used
DefaultAddressValidator and related AbstractAssetWithDefaultValidatorTest.
Rationale: it is not obvious whether "P2P network" in GUI
refers to Bitcoin network, Tor network, traded altcoin network,
or Bisq.
Protobuf got updated to the latest released version 3.9.1.
The main motivation was to fix the following annoying warnings:

WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by com.google.protobuf.UnsafeUtil (file:/home/qertoip/.gradle/caches/modules-2/files-2.1/com.google.protobuf/protobuf-java/3.5.1/8c3492f7662fa1cbf8ca76a0f5eb1146f7725acd/protobuf-java-3.5.1.jar) to field java.nio.Buffer.address
WARNING: Please consider reporting this to the maintainers of com.google.protobuf.UnsafeUtil
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

Additionally, protobuf-gradle-plugin got updated to 0.8.10.
wiz and others added 21 commits September 11, 2019 20:44
We remove the CapabilityRequiringPayload interface to avoid risks
that new BSQ blocks are not well distributed in case the capability is
not exchanged at the time when the message is sent. We need to improve
the capability handling so that we can be sure that we know the actual
capability of the peer.
…apability

Remove CapabilityRequiringPayload from NewBlockBroadcastMessage
…-and-dates-for-v1.1.6

Update data stores and dates for v1.1.6
We remove CapabilityRequiringPayload as it would cause problems if the
lite node connects to a new seed node and they have not exchanged
capabilities already. We need to improve capability handling the we
can re-enable it again. As this message is sent any only to seed nodes
it does not has any effect. Even if a lite node receives it it will
be simply ignored.
…RequiringPayload-from-GetBlocksRequest

Remove CapabilityRequiringPayload from GetBlocksRequest
…network#3258)

* Fix various bugs related to Japan Bank Transfer payment method

* Add missing call to addFormForBuyer(), improve BuyerStep2View UI
* Fix Account Creation UI elements width to fill entire pane
* Fix Account Creation UI elements padding to avoid overlap
* Tweak trade display popup text and various strings
* Remove @deprecated tag

* Remove unnecessary line break

* Improve layout of fields
…into v1.1.6-for-seednodes

# Conflicts:
#	common/src/main/java/bisq/common/app/Capability.java
#	core/src/main/java/bisq/core/dao/node/messages/NewBlockBroadcastMessage.java
#	core/src/main/java/bisq/core/setup/CoreNetworkCapabilities.java
@wiz
Copy link
Contributor

wiz commented Sep 14, 2019

Instead of reviewing this PR, how about we abandon the seednode_temporaryfix branch, and just make a new branch off the v1.1.6 release branch, with these 2 commits cherry-picked:

aa82dae Fix automatic 24 hour restart
1d7a063 Shutdown seed nodes every 24h

@wiz
Copy link
Contributor

wiz commented Sep 14, 2019

Actually, I just checked and it's the same end-result, so it doesn't matter. ACK 😁

@wiz
Copy link
Contributor

wiz commented Sep 14, 2019

Now running this branch on jhgcy2won7xnslrb.onion and seems 👍

Copy link
Contributor

@chimp1984 chimp1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit d429e12 into bisq-network:seednode_temporaryfix Sep 15, 2019
@ripcurlx ripcurlx deleted the v1.1.6-for-seednodes branch September 26, 2019 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.