Code

Add rpc wallet protection endpoints#4214

Code

Merged

cbeams merged 24 commits intobisq-network:masterbisq-network/bisq:masterfrom ghubstan:rpc-wallet-protectionghubstan/bisq:rpc-wallet-protectionCopy head branch name to clipboardMay 18, 2020

+443-121

Commits

Commits on Apr 29, 2020

• Add rpc wallet protection endpoints

  Show description for de50692
  ghubstan

  committed
  de50692

  Copy full SHA for de50692

Commits on Apr 30, 2020

• Handle unlockwallet parameter errors

  ghubstan

  committed
  2096275

  Copy full SHA for 2096275

• Add wallet protection methods to printHelp(opts)

  ghubstan

  committed
  ca68d05

  Copy full SHA for ca68d05

• Renamed tempWalletPassword -> tempLockWalletPassword

  Show description for c5fcafb
  ghubstan

  committed
  c5fcafb

  Copy full SHA for c5fcafb

Commits on May 1, 2020

• Improve gRPC error handling

  Show description for 2a9d1f6
  ghubstan

  committed
  2a9d1f6

  Copy full SHA for 2a9d1f6

Commits on May 3, 2020

• Refactor grpc wallet service

  Show description for c7a6c87
  cbeams

  committed
  c7a6c87

  Copy full SHA for c7a6c87

• Generalize gRPC exception message cleanup

  cbeams

  committed
  6334c54

  Copy full SHA for 6334c54

• Return long vs Tuple2 from CoreWalletService#getAvailableBalance

  Show description for 163061a
  cbeams

  committed
  163061a

  Copy full SHA for 163061a

• Return void vs Tuple2 from CoreWalletService#setWalletPassword

  Show description for 9164579
  ghubstan

  committed
  9164579

  Copy full SHA for 9164579

• Return void vs Tuple2 from CoreWalletService#removeWalletPassword

  Show description for feafd0c
  ghubstan

  committed
  feafd0c

  Copy full SHA for feafd0c

• Remove obsolete try/catch block in #setWalletPassword

  cbeams

  committed
  ab17b67

  Copy full SHA for ab17b67

• Return void vs Tuple2 from CoreWalletService#lockWallet

  Show description for ec2ee45
  ghubstan

  committed
  ec2ee45

  Copy full SHA for ec2ee45

• Return void vs Tuple2 from CoreWalletService#unlockWallet

  Show description for 3ef7286
  ghubstan

  committed
  3ef7286

  Copy full SHA for 3ef7286

• Add missing return statement in CoreWalletService#setWalletPassword

  Show description for f5a4ca5
  ghubstan

  committed
  f5a4ca5

  Copy full SHA for f5a4ca5

Commits on May 4, 2020

• Refactor setwalletpassword handling to eliminate duplication

  cbeams

  committed
  b0e5da8

  Copy full SHA for b0e5da8

• Tighten up error handling

  Show description for d48f9eb
  cbeams

  committed
  d48f9eb

  Copy full SHA for d48f9eb

• Remove unlockwallet timeout variable initializer

  Show description for 9b156b8
  ghubstan

  committed
  9b156b8

  Copy full SHA for 9b156b8

Commits on May 6, 2020

• Factor out two small duplcated code blocks

  ghubstan

  committed
  fbb025a

  Copy full SHA for fbb025a

• Cache temp key and crypter scrypt in unlockwallet

  Show description for 4262f29
  ghubstan

  committed
  4262f29

  Copy full SHA for 4262f29

• Backup wallets after each encrypt/decrypt operation

  Show description for 24248d4
  ghubstan

  committed
  24248d4

  Copy full SHA for 24248d4

Commits on May 7, 2020

• Cache aesKey in unlockwallet, clear it in lockwallet

  Show description for a79ae57
  ghubstan

  committed
  a79ae57

  Copy full SHA for a79ae57

Commits on May 13, 2020

• Fix unlockwallet timeout override bug

  Show description for 9178ad7
  ghubstan

  committed
  9178ad7

  Copy full SHA for 9178ad7

Commits on May 18, 2020

• Wrap comments at 90 chars

  Show description for d53cc38
  cbeams

  committed
  d53cc38

  Copy full SHA for d53cc38

• Remove unused import

  Show description for 7f05f37
  cbeams

  committed
  7f05f37

  Copy full SHA for 7f05f37