Minor bug fixes for XMR tx proof feature #4490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix missing CSS color code xmr-orange, was missing from dark mode. Fix log message spelling/typo errors. Removed 2 fixes from SellerStep3View so that chimp1984 can make changes. Remove address validator from XMR service address settings because it does not support https prefix.
ghost
dismissed
ripcurlx
approved these changes
Sep 7, 2020
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useXmrTxProofflag was used before initialization in cases whereaddContent()is called beforeactivate().xmr-orange, was missing from dark mode.[edit] @chimp1984 wants to work on SellerStep3View.java so I have removed it from this PR.