Fix trade protocol issues #4533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems in the past there was partial support for uid but now all trade messages have uid.
|
I ACK the logo :) ... awesome! As for the rest, my knowledge is limited so concept ACK only, seems like some good changes that may help decrease the amount of stuck trades we get. |
# Conflicts: # core/src/main/java/bisq/core/offer/placeoffer/tasks/CreateMakerFeeTx.java
sqrrm
approved these changes
Sep 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comes with a few smaller fixes and improvements in the trade protocol area.
Most importantly it comes with a nice bisq ascii art banner in the logs at startup ;-)