Start pricenode providers asynchronously

pricenode/src/main/java/bisq/price/PriceProvider.java

@@ -17,12 +17,15 @@
 
 package bisq.price;
 
+import bisq.common.UserThread;
+
 import org.springframework.context.SmartLifecycle;
 
 import java.time.Duration;
 
 import java.util.Timer;
 import java.util.TimerTask;
+import java.util.concurrent.TimeUnit;
 import java.util.function.Supplier;
 
 import org.slf4j.Logger;
@@ -45,17 +48,19 @@ public PriceProvider(Duration refreshInterval) {
 
     @Override
     public final T get() {
-        if (!isRunning())
-            throw new IllegalStateException("call start() before calling get()");
-
         return cachedResult;
     }
 
     @Override
     public final void start() {
-        // we call refresh outside the context of a timer once at startup to ensure that
-        // any exceptions thrown get propagated and cause the application to halt
-        refresh();
+        // do the initial refresh asynchronously
+        UserThread.runAfter(() -> {
+            try {
+                refresh();
+            } catch (Throwable t) {
+                log.warn("initial refresh failed", t);
+            }
+        }, 1, TimeUnit.MILLISECONDS);
 
         timer.scheduleAtFixedRate(new TimerTask() {
             @Override

pricenode/src/main/java/bisq/price/mining/FeeRateService.java

@@ -27,13 +27,17 @@
 import java.util.concurrent.atomic.AtomicInteger;
 import java.util.concurrent.atomic.AtomicLong;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 /**
  * High-level mining {@link FeeRate} operations.
  */
 @Service
 class FeeRateService {
 
     private final List<FeeRateProvider> providers;
+    protected final Logger log = LoggerFactory.getLogger(this.getClass());
 
     /**
      * Construct a {@link FeeRateService} with a list of all {@link FeeRateProvider}
@@ -56,6 +60,10 @@ public Map<String, Object> getFees() {
         // Process each provider, retrieve and store their fee rate
         providers.forEach(p -> {
             FeeRate feeRate = p.get();
+            if (feeRate == null) {
+                log.warn("feeRate is null, provider={} ", p.toString());
+                return;
+            }
             String currency = feeRate.getCurrency();
             if ("BTC".equals(currency)) {
                 sumOfAllFeeRates.getAndAdd(feeRate.getPrice());

pricenode/src/main/java/bisq/price/spot/ExchangeRateService.java

@@ -61,6 +61,8 @@ public Map<String, Object> getAllMarketPrices() {
         Map<String, ExchangeRate> aggregateExchangeRates = getAggregateExchangeRates();
 
         providers.forEach(p -> {
+            if (p.get() == null)
+                return;
             Set<ExchangeRate> exchangeRates = p.get();
 
             // Specific metadata fields for specific providers are expected by the client,
@@ -136,6 +138,8 @@ private Map<String, ExchangeRate> getAggregateExchangeRates() {
     private Map<String, List<ExchangeRate>> getCurrencyCodeToExchangeRates() {
         Map<String, List<ExchangeRate>> currencyCodeToExchangeRates = new HashMap<>();
         for (ExchangeRateProvider p : providers) {
+            if (p.get() == null)
+                continue;
             for (ExchangeRate exchangeRate : p.get()) {
                 String currencyCode = exchangeRate.getCurrency();
                 if (currencyCodeToExchangeRates.containsKey(currencyCode)) {

pricenode/src/test/java/bisq/price/mining/providers/MempoolFeeRateProviderTest.java

@@ -28,6 +28,7 @@
 
 import org.junit.jupiter.api.Test;
 
+import static java.lang.Thread.sleep;
 import static org.junit.Assert.assertTrue;
 
 /**
@@ -66,6 +67,9 @@ protected FeeRate doGet() {
 
         // Initialize provider
         dummyProvider.start();
+        try {
+            sleep(1000);
+        } catch (InterruptedException e) { }
         dummyProvider.stop();
 
         return dummyProvider;
@@ -86,6 +90,9 @@ protected FeeRate doGet() {
 
         // Initialize provider
         dummyProvider.start();
+        try {
+            sleep(1000);
+        } catch (InterruptedException e) { }
         dummyProvider.stop();
 
         return dummyProvider;

pricenode/src/test/java/bisq/price/spot/ExchangeRateServiceTest.java

@@ -44,6 +44,7 @@
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
 
+import static java.lang.Thread.sleep;
 import static java.util.Arrays.asList;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertNotEquals;
@@ -287,6 +288,9 @@ protected Set<ExchangeRate> doGet() {
 
         // Initialize provider
         dummyProvider.start();
+        try {
+            sleep(1000);
+        } catch (InterruptedException e) { }
         dummyProvider.stop();
 
         return dummyProvider;
@@ -322,6 +326,9 @@ protected Set<ExchangeRate> doGet() {
 
         // Initialize provider
         dummyProvider.start();
+        try {
+            sleep(1000);
+        } catch (InterruptedException e) { }
         dummyProvider.stop();
 
         return dummyProvider;