Prevent negative suggested mining fee when burning BSQ for fees #5643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Negative mining fees could be shown in the make/take offer summary popup when BSQ is used for fees and the BTC sats value of the BSQ is greater than the calculated transaction fee.
Using BSQ to pay trade fees burns the BSQ effectively paying miners with those sats. A bug surfaced whereby negative mining fees could be displayed, giving a false/confusing impression to users. Note that this is a display issue only, there were no problems with the trading transactions themselves.
After this fix, the displayed mining fee cannot be negative.
In these examples the BSQ fee rate (Param.java) was artificially increased to 100 BSQ/BTC producing larger than usual BSQ fees and triggering the bug in order to validate the fix.