Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-logic: Download and Verify Electrum Binaries #413

Merged

Conversation

alvasw
Copy link
Contributor

@alvasw alvasw commented Jun 30, 2022

The new BisqElectrumPlugin downloads and verifies the Electrum binaries for Linux, OSX, and Windows. The PGP public keys and the fingerprints of the Electrum developers are hardcoded in the plugin. Consumers of the plugin can set the electrumVersion property to specify the version.

The new BisqElectrumPlugin downloads and verifies the Electrum binaries
for Linux, OSX, and Windows. The PGP public keys and the fingerprints of
the Electrum developers are hardcoded in the plugin. Consumers of the
plugin can set the electrumVersion property to specify the version.
@alvasw alvasw requested a review from chimp1984 June 30, 2022 02:48
Copy link
Contributor

@chimp1984 chimp1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@chimp1984 chimp1984 merged commit 9ff6582 into bisq-network:main Jun 30, 2022
@alvasw alvasw deleted the download_and_verify_electrum_binaries branch August 1, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants