Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 60 #1577

Closed
kciouv opened this issue Jul 3, 2024 · 10 comments
Closed

For Cycle 60 #1577

kciouv opened this issue Jul 3, 2024 · 10 comments
Labels
was:not submitted Indicates that a compensation request was not submitted for DAO voting
Milestone

Comments

@kciouv
Copy link

kciouv commented Jul 3, 2024

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

  • BSQ requested: 176.2
  • USD requested: 400
  • BSQ rate: 2.27 USD per BSQ
  • Previous compensation request (if applicable): I did not take compensation requests during the last cycle.

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
Fix incorrect newline insertion behavior in chat messages dev 50 bisq-network/bisq2#2226 Fixes bisq-network/bisq2#2176
Add sidebar copy buttons to UserProfileSidebar dev 100 bisq-network/bisq2#2293 Partial fix for bisq-network/bisq2#2228; creates buttons on sidebar to copy botId and getAddressByTransport.
Improve error popup dev 200 bisq-network/bisq2#2334 Many cycles of iteration (16 commits over four days) based on external feedback that were ultimately merged into this PR to fix bisq-network/bisq2#2291.
Refactor toBisq1RoleTypeName dev 50 bisq-network/bisq2#2196 Low-significance refactor to remove a TODO from codebase.

Contributions in progress

Provide links to work you're involved with that is still in progress. This section is optional (the linter ignores it), and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same.

@kciouv
Copy link
Author

kciouv commented Jul 3, 2024

Trying to get a feel for what's fair as far as compensation requests go (my standard rates aren't really directly comparable because of extreme specialization in my career, and especially not given my current lack of familiarity with the codebase); tried to ballpark based on looking at historical comp requests, but will happily tweak to fit what's fair upon further feedback and would fully understand something lower. This was a bit of an odd case with bisq-network/bisq2#2296 and bisq-network/bisq2#2307 taking up a higher-than-normal portion of time while also being superseded by bisq-network/bisq2#2334, so I'm aware that it might look pretty strange (again, more than happy to change amounts on request).

@MwithM MwithM added this to the Cycle 60 milestone Jul 4, 2024
@HenrikJannsen
Copy link

@kciouv The compensation should reflect the added value to Bisq. I am aware that this is not always easy to estimate.
To break down each CP with a USD value makes it already a bit easier. To calculate personal rates can help for one self but should not be considered as the model to define the values, specially in early phases as getting familiar with the code base is not compensated in Bisq.

I will DM you my personal estimations to the PRs... feel free to ignore those, just my personal feedback.

@HenrikJannsen
Copy link

And just out of curiosity, why has the only entry with a dedicated value 0.32 USD? I assume it happened by mistake....

@kciouv
Copy link
Author

kciouv commented Jul 4, 2024

@HenrikJannsen yeah sure, agree w/ your recommended changes

wrote this after a long flight and wasn't paying much attention; this was essentially an attempt at Cunningham's Law ("the best way to get the right answer on the internet is not to ask a question; it's to post the wrong answer.") because I couldn't find a recent (itemized) example of pricing.

@kciouv
Copy link
Author

kciouv commented Jul 4, 2024

(and the .32 was just to get the bsq number even)

@axpoems
Copy link

axpoems commented Jul 4, 2024

I don't see the reason to stop pursuing the even BSQ number.

@MwithM
Copy link
Contributor

MwithM commented Jul 4, 2024

When the bot that parses the compensation requests backs to work again, I think it won't like the total 400 USD in the last row, and it will invalidate the parsing.
Please remove that row, it's not necessary as the total amount is already in the second line (USD requested).

@kciouv
Copy link
Author

kciouv commented Jul 5, 2024

@MwithM done

@HenrikJannsen
Copy link

@HenrikJannsen yeah sure, agree w/ your recommended changes

wrote this after a long flight and wasn't paying much attention; this was essentially an attempt at Cunningham's Law ("the best way to get the right answer on the internet is not to ask a question; it's to post the wrong answer.") because I couldn't find a recent (itemized) example of pricing.

Good to know. Next time I think twice where I spend my time...

@MwithM
Copy link
Contributor

MwithM commented Jul 17, 2024

Compensation request was not submitted.

@MwithM MwithM added the was:not submitted Indicates that a compensation request was not submitted for DAO voting label Jan 28, 2025
@MwithM MwithM closed this as completed Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
was:not submitted Indicates that a compensation request was not submitted for DAO voting
Projects
Archived in project
Development

No branches or pull requests

4 participants