For Cycle 5

[battleofwizards]

Summary

• BSQ requested: 8450

Contributions delivered

Develop dropdown autocomplete and integrate it on major menu tabs (Market, Buy, Sell)

bisq-network/bisq#3139
bisq-network/bisq#3124
bisq-network/bisq#3172

BSQ: 5800

Value: significantly better user experience for all Bisq users, developers and testers. Trading pairs and markets are easier to discover. Bisq feels more modern.

This "obvious" feature was missing from Bisq for years for a reason: development and testing was pretty time consuming and in fact turned out to be a little Vietnam. The JavaFX (ecosystem) does not provide proper autocomplete component and the solution had to be integrated in a complex context of existing GUI.

Fix broken CSV exports

bisq-network/bisq#3090

Value: exporting reports to CSV is working again.

BSQ: 500

Document text translation process from programmer's point of view

https://github.com/bisq-network/bisq/blob/master/docs/translation-process.md

BSQ: 200

Change in GUI "P2P network" with "Bisq network" (globally, in English)

bisq-network/bisq#3098

BSQ: 75

Auto remove whitespace in the IBAN input field

bisq-network/bisq#3103
BSQ: 75

Codebase sustainability work

Remove bcprov from direct dependencies - a major step towards eventually removing Bouncy Castle
bisq-network/bisq#3195
Remove json-simple dependency
bisq-network/bisq#3196
Remove deprecated DefaultAddressValidator
bisq-network/bisq#3089
Remove legacy hack from build.gradle installDist task
bisq-network/bisq#3087
Update protobuf to fix annoying warnings
bisq-network/bisq#3097
Do not specify indirect module dependencies
bisq-network/bisq#3167

BSQ: 1600

Value: every little cleanup allows other programmers to work a bit faster. In fact, relentless cleaning up the codebase is critical to any project's sustainability. Dependency minimization reduces attack surface. Select changes may look tiny but required research and testing effort.

Minor PR and code reviews

bisq-network/bisq#3092
bisq-network/bisq#3134
bisq-network/bisq#3132
bisq-network/bisq#3133
bisq-network/bisq#3102

BSQ: 200