For Cycle 27

[wallclockbuilder]

Summary

• BSQ requested: 502.44
• USD requested: 618.00
• BSQ rate: 1.23 USD per BSQ

Contributions delivered

Cycle 23

Title	Team	USD	Link	Notes
Replace slack with Keybase	dev	5	5288	PR
Release v1.6.0	dev	441	Report	Testing
Release v1.6.1	dev	0	Report	Testing
Improve takeoffer error handing	dev	17	5294	Code Review
Fix dark mode readibility of specific texts - Part 2	dev	7	5332	Code Review
Delete issue template file	dev	0	5353	Code Review
Remove the apparent link for cases where the trade is not available for mediators	dev	37	5354	Code Review
Add api method createcryptopaymentacct	dev	28	5356	Code Review
Allow default fee values in leniency check	dev	21	5365	Code Review
Fix NPE in Portfolio View when market price n/a	dev	31	5385	Code Review
Update commands for mediator/refund agent	dev	22	5323	Merged PR
Fix typo in function name	dev	9	5291	Merged PR
Replace slack with Keybase	dev	0	5288	Merged PR
Transaction Details dialog should display exact amount of BTC sent. No more. No less.	dev	0	5305	Issue leading to Merged PR

Contributions in progress

Title	Team	USD	Link	Notes
Update testing steps.	dev	-	5317	-
Change file mentioned to from .desktop to .service	dev	-	5319	-
Generate more than 1 block(regtest)	dev	-	5355	-
Add tooltip(on hover) to BondUnlockTime column title	dev	-	5275	-
Temporary solution for high mining fees	dev	-	5282	-
Publish ALL pending offers when mining fee is low.	dev	-	5296	-
Unhide custom mining fee option(from settings-page to send-bitcoin-page)	dev	-	5298	-
Unhide custom mining fee option for sending BSQ	dev	-	5304	-
Let user enter human friendly time for locking up BSQ. Let Bisq handle the conversion to block time.	dev	-	5306	-

[ghost]

Errors

USD amount not specified in summary section
BSQ amount not specified in summary section
No compensation lineitems found.

[ghost]

Info

Read BSQ amount from summary: 283.49
Read USD amount from summary: 618
Read BSQ rate from summary: 2.18
Parsed lineitem: {"team":"dev","amount":5}
Parsed lineitem: {"team":"dev","amount":441}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":17}
Parsed lineitem: {"team":"dev","amount":7}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":37}
Parsed lineitem: {"team":"dev","amount":28}
Parsed lineitem: {"team":"dev","amount":21}
Parsed lineitem: {"team":"dev","amount":31}
Parsed lineitem: {"team":"dev","amount":22}
Parsed lineitem: {"team":"dev","amount":9}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}

Errors

Incorrect BSQ rate specified: 2.18, expected: 1.23
ERROR: Total BSQ does not match the sum of line items:

• Summary total: 283.49 BSQ
• Calculated total: 502.44 BSQ

[wallclockbuilder]

Reference: #819

[ghost]

Info

Read BSQ amount from summary: 283.49
Read USD amount from summary: 618
Read BSQ rate from summary: 2.18
Parsed lineitem: {"team":"dev","amount":5}
Parsed lineitem: {"team":"dev","amount":441}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":17}
Parsed lineitem: {"team":"dev","amount":7}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":37}
Parsed lineitem: {"team":"dev","amount":28}
Parsed lineitem: {"team":"dev","amount":21}
Parsed lineitem: {"team":"dev","amount":31}
Parsed lineitem: {"team":"dev","amount":22}
Parsed lineitem: {"team":"dev","amount":9}
Parsed lineitem: {"team":"dev","amount":0}
Parsed lineitem: {"team":"dev","amount":0}

Errors

Incorrect BSQ rate specified: 2.18, expected: 1.23
ERROR: Total BSQ does not match the sum of line items:

• Summary total: 283.49 BSQ
• Calculated total: 502.44 BSQ

[wallclockbuilder]

Reference: #887 (comment)

[wallclockbuilder]

Tx ID: b7676812f3b62f274b6cb06cddf64c49fe23568f8a830ca8d4b2a878b70ff7c5

[ripcurlx]

@wallclockbuilder Sorry for my late review as I had personal issues. Unfortunately I won't be able to complete the review for this cycle. Still I'll respond to this issue for documentation purpose latest tomorrow. I saw that you published your CR already so I'll try to review it in-time for everyone else to vote on. But worst-case you have to re-submit it in the next cycle.

[ripcurlx]

@wallclockbuilder For your v1.6.0 release test report. Could you please post here the export of your test payment accounts (fiat and alt) as you tested all of them. It would help other devs setting up all of them manually. Also in this test report it says you tested all trading test cases on Testnet (which is not possible, as it is not running anymore). How did you test this?

[ripcurlx]

Code Reviews:

@ bisq-network/bisq#5365: For contributors without a track record I don't think it is a good precedent to compensate a utACK.

In general I think to ask for code review compensation without contributing to the codebase first (more than fixing typos) would send the wrong signal for future CR code reviews (what would prevent someone just to utACK/ACK every PR and ask for compensation without doing anything)

[MwithM]

Closed as rejected.