Confusion with Create Wallet menu options

[Rspigler]

This is in regards to bitcoin/bitcoin#15450

If you check 'Disable Private Keys', is that not initially a Blank Wallet, until you import an xpub?
I don't understand what the difference would be between checking just 'Disable Private Keys', and checking 'Disable Private Keys' and 'Make Blank Wallet'.

Should checking 'Disable Private Keys' automatically check 'Make Blank Wallet'? (But not vice versa - Making a Blank Wallet with/without Disabling Private Keys affects the future ability to import.)

But then I am concerned that this would be very confusing for the end user. Enabling 'Encrypt Wallet' already disables 'Disable Private Keys'.

[Rspigler]

Did not mean to add a Bug label

[achow101]

Disable private keys means that the wallet cannot have private keys ever. Make blank wallet means that the wallet starts out with nothing in it, but private keys can be added to the wallet via import or sethdseed.

Both options begin very similarly in that the wallet doesn't have any keys or scripts.

Encrypt wallet is mutually exclusive with disable private keys because encrypting only encrypts the private keys. When the wallet doesn't have any private keys, there's nothing to encrypt so the option is useless.

[Rspigler]

I understand all of that.

My point then, is that there is no difference between a wallet created with 'Disable Private Keys' & 'Make Blank Wallet' vs. just 'Disable Private Keys'. Should enabling 'Disable Private Keys' then automatically enable 'Make Blank Wallet'?

There is; however, a difference between a wallet created with 'Make Blank Wallet' vs. 'Make Blank Wallet' & 'Disable Private Keys', as it affects future imports of private keys/HD seeds. So they shouldn't be combined into one item.

'Encrypt Wallet' correctly disables 'Disable Private Keys', but I'm starting to get concerned that there are just a lot of variables now that could confuse the end user, so I wanted to note that.

Thinking about this more: Should enabling 'Disable Private Keys' also disable 'Encrypt Wallet', just as enabling 'Encrypt Wallet' disables 'Disable Private Keys', as encrypt wallet is mutually exclusive with disabled private keys?

[Bosch-0]

I've got a WIP design related to this issue that more clearly explains each option, you can view it here: https://www.figma.com/file/FJ02rY3m8V9ZCDvoXjW39W/Bitcoin-Core?node-id=281%3A0

[Rspigler]

I like that a lot! (I had some difficulty in opening this in a DispVM, maybe paste screenshots/code here for people who don't want to leave github to review?)

Some typos in the 'Blank Wallet' descriptions; example "A blank wallet has will generate..."

In the 1.2 modal; are you able to click more than one wallet option? Should selecting one, grey out the others?

[Rspigler]

Referencing this here:
bitcoin/bitcoin#17879 (comment)

[Bosch-0]

I'll upload a screenshot once I have made some changes - though there are many UI/UX changes being made other than just the initial menu options so ill likely open a new issue.

Fixed that typo cheers, no spellcheck on Figma - usually clean up those details at the end ;)

I'll change these to radio inputs rather than check boxes with only one being able to be selected.

[ghost]

I've got a WIP design related to this issue that more clearly explains each option, you can view it here: https://www.figma.com/file/FJ02rY3m8V9ZCDvoXjW39W/Bitcoin-Core?node-id=281%3A0

@Bosch-0 This looks good.