Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Rename arm to arm32 and check if it's really supported #1034

Closed
real-or-random opened this issue Dec 7, 2021 · 5 comments · Fixed by #1304
Closed

build: Rename arm to arm32 and check if it's really supported #1034

real-or-random opened this issue Dec 7, 2021 · 5 comments · Fixed by #1304

Comments

@real-or-random
Copy link
Contributor

See the discussion starting here: #936 (comment)

@Psycho-Pirate
Copy link

I would like to work on this. Please tell me which files need to be updated.

@real-or-random
Copy link
Contributor Author

Have a look at configure.ac. You need to be familiar with shell scripting, and you need to figure out a way to detect arm32 support. The autoconf documentation may be useful. (https://www.gnu.org/software/autoconf/)

@Psycho-Pirate
Copy link

Thanks, I will look into this!

@real-or-random
Copy link
Contributor Author

@Psycho-Pirate Are you still interested in working on this?

@hebasto
Copy link
Member

hebasto commented May 11, 2023

At least in CMake-based build system, it seems worth making the SECP256K1_ASM option actually dependent on the value of the CMAKE_SYSTEM_PROCESSOR variable. Then ON/OFF values will be enough for it with defaults as follows:

  • ON for x86_64
  • OFF for arm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants