Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minified browser javascript file missing in v0.2.0 release #148

Closed
pyramids opened this issue Apr 23, 2014 · 2 comments
Closed

Minified browser javascript file missing in v0.2.0 release #148

pyramids opened this issue Apr 23, 2014 · 2 comments

Comments

@pyramids
Copy link

I'm adding version 0.1.3 of this library to cdns (pending for cdnjs, accepted at jsdelivr).

If there was an official browser-ready and minified build for version 0.2.0, I'd like to do the same with that version. Could that (or a future) release be given such a distribution file?

Even better: Could you promise to keep doing that to enable auto-updating cdnjs from this repository?

@weilu
Copy link
Contributor

weilu commented Apr 23, 2014

Minified scripts shouldn't be kept in version control. Same rule goes for anything that can be generated from source.

The minified code can be easily generated: https://github.com/bitcoinjs/bitcoinjs-lib#browser. If you have a server somewhere you can run a cron job there to fetch the latest tag, npm run-script compile and auto-update cdnjs from there?

@pyramids
Copy link
Author

I'll add version 0.2.0 this way but automating it is a bit tricky because I don't want to dedicate my own server to the task and the CDNs naturally aren't keen to provide a build environment for everything they are hosting.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants