Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffer isn't exported by browserify #333

Closed
adatta02 opened this issue Dec 27, 2014 · 3 comments
Closed

Buffer isn't exported by browserify #333

adatta02 opened this issue Dec 27, 2014 · 3 comments

Comments

@adatta02
Copy link

Awesome library. I was experimenting with using it to create raw transactions in a browser and just noticed that Buffer doesn't get exported so it's not usable by client code.

Noticed this on 1.4.2 when trying to use bitcoin.scripts.nullDataOutput

Sorry for not submitting a PR - I'm not familiar with browserify at all.

@weilu
Copy link
Contributor

weilu commented Dec 27, 2014

We've had multiple discussions around this. Please see: #308 Kindly close this if your issue is addressed by the discussion linked above.

@adatta02
Copy link
Author

Gotcha - sorry I missed that thread.

Not sure if you'd be open to adding a note in the https://github.com/bitcoinjs/bitcoinjs-lib#browser section maybe?

@dcousens
Copy link
Contributor

@adatta02 it'd be awesome if you could provide an opinion in this thread: #315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants