Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test fixtures for Block/Transaction w/ signed int version #663

Closed
dcousens opened this issue Oct 12, 2016 · 2 comments
Closed

Add test fixtures for Block/Transaction w/ signed int version #663

dcousens opened this issue Oct 12, 2016 · 2 comments
Assignees
Labels

Comments

@dcousens dcousens self-assigned this Oct 12, 2016
@dcousens dcousens changed the title Add test fixtures for Block/Transaction signed versions Add test fixtures for Block/Transaction w/ signed int version Oct 14, 2016
@afk11
Copy link
Contributor

afk11 commented Oct 27, 2016

I added small tests for both of these in the PR. (The ones for transaction might demonstrate the effect more - version/locktime have the serialization, but are interpreted differently)

https://github.com/bitcoinjs/bitcoinjs-lib/pull/662/files#diff-bf93e9f5180db5c003ef49fd2fb9a5acR9
https://github.com/bitcoinjs/bitcoinjs-lib/pull/662/files#diff-47fd755279d6a2638f13d68e56a3304dR90

@dcousens
Copy link
Contributor Author

@afk11 👍 , in future lets see if we can't put them in the vectors file though.

@dcousens dcousens closed this as completed Nov 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants