Add manifest import paths as a variable

[sonniesedge]

The import path is used in multiple places. It would make sense to variablise this.

[sonniesedge]

Ah, there might be a problem with that: sass/sass#279

[planktonic]

Could be fixed using the workaround here? sass/sass#279 (comment)

[sonniesedge]

That's a runtime level workaround though. Not sure it's something that we can affect via the Bitstyles code. :(

[planktonic]

Yes, that’s definitely true — it’d be required in the local project configuration.

So today’s findings: using https://github.com/bitcrowd/bitstyles/releases/tag/v0.2.1 (based on my PR replacing normalise with sass version), adding the node_modules to sass load path (reasonable expectation, have to do this in rails), and the bitstyles folder to the sass load path (less reasonable, but maybe ok for now):

'./node_modules/bitstyles/stylesheets',
'node_modules'

…and everything works well (requires npm v3+ presumably, not tested that yet).

The only other option I see right now is to use two different versions of the manifest (with different paths), but I’ll look into this more tomorrow.

[planktonic]

Further findings after looking at how foundation & bootstrap do this:

Our options as I see it:

• instruct users to set the path variable in their local project
• instruct users to write @import '<location-of-bitstyles-here>/objects/blah';
• provide manifest files in bitstyles that cover every eventuality for the location of node_modules/bower_components

The first of these seems the simplest and most robust — it’s one change for the local project, no added maintenance for bitstyles — and cross-package-manager-compatible.

This is how foundation sass does it (they provide CLI tools to automate that and the rest of the install process but also provide manual install instructions), and how most guides suggest using bootstrap-sass (the remaining guides I’ve read simply suggest @import 'node_modules/bootstrap-sass/scss/… for every import).

One potentially interesting point for the npm version — bootstrap v4 has a sass key in the package.json that specifies the location of the sass files within the repo. Combined with the location of node_modules (which also needs to be set if sass is to access any css in there) this could be used to create the loadpath, at least within an npm script (see this stack overflow question).

Right now though I’d suggest we keep it simple, and instruct users to add bitstyles to their loadpath in our readme.