Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Push] Show notification on push notification (until sync is started) #1014

Closed
rfc2822 opened this issue Sep 10, 2024 · 3 comments · Fixed by #1043
Closed

[Push] Show notification on push notification (until sync is started) #1014

rfc2822 opened this issue Sep 10, 2024 · 3 comments · Fixed by #1043
Assignees
Labels
enhancement New feature or request

Comments

@rfc2822
Copy link
Member

rfc2822 commented Sep 10, 2024

When a push notification comes in, we enqueue a sync worker for the respective account. However, this worker will often not be executed immediately, depending on the priority of the push message, battery saving settings etc.

So we should probably do what Android apps are expected to do [1, 2, 3, 4] when a push notification comes in:

  1. Enqueue a one-time sync worker.
  2. Show a low-priority notification with some text like "Server-side changes pending".
  3. If the user opens DAVx⁵ over the notification, the work will usually start because DAVx⁵ is in foreground. Alternatively, the worker may be as a background job at some time without user interaction.
  4. As soon as the worker starts, it should remove the notification.
@rfc2822 rfc2822 added the enhancement New feature or request label Sep 10, 2024
@rfc2822 rfc2822 transferred this issue from bitfireAT/nc_ext_dav_push Sep 10, 2024
@rfc2822
Copy link
Member Author

rfc2822 commented Sep 16, 2024

  • Channel: CHANNEL_STATUS
  • Use setGroup

@rfc2822
Copy link
Member Author

rfc2822 commented Sep 16, 2024

How should the architecture be? Given that:

  • push receiver shows "push received – sync pending" notification (per account/authority)
  • (local changes may show a "local changes – sync pending" notification, again per account/authority)
  • all notifications for a given account/authority should be dismissed when the respective sync is run

@rfc2822 rfc2822 assigned sunkup and ArnyminerZ and unassigned sunkup Sep 19, 2024
@rfc2822
Copy link
Member Author

rfc2822 commented Sep 22, 2024

As we have talked at the conf. Doesn't have to be a perfect design at the first try, but let's try

@ArnyminerZ ArnyminerZ linked a pull request Sep 25, 2024 that will close this issue
4 tasks
@github-project-automation github-project-automation bot moved this from Todo to Done in DAVx⁵ Releases Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants