Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Push] Upon notification, only enqueue sync for the respective service type #1152

Closed
rfc2822 opened this issue Dec 4, 2024 · 3 comments · Fixed by #1175
Closed

[Push] Upon notification, only enqueue sync for the respective service type #1152

rfc2822 opened this issue Dec 4, 2024 · 3 comments · Fixed by #1175
Assignees
Labels
refactoring Internal improvement of existing functions

Comments

@rfc2822
Copy link
Member

rfc2822 commented Dec 4, 2024

Currently, UnifiedPushReceiver enqueues syncs for all authorities (contacts, calendar, tasks) and all collections of the account.

While it's more complicated to enqueue only a sync for the affected collection (because we would have to keep track of already requested ones, merge when a new sync is enqueued etc), it should be relatively easy to only sync

  • contacts when the push message is for a CardDAV collection,
  • calendars/tasks when the push message is for a CalDAV collection.
@rfc2822 rfc2822 added the refactoring Internal improvement of existing functions label Dec 4, 2024
@ArnyminerZ
Copy link
Member

ArnyminerZ commented Dec 8, 2024

Is the information required already provided by the Nextcloud extension right? I mean, to know which collection has been updated.

@rfc2822
Copy link
Member Author

rfc2822 commented Dec 12, 2024

Is the information required already provided by the Nextcloud extension right? I mean, to know which collection has been updated.

Yes, the collection can be derived from the topic – we can look in the Collections table which collection has the topic that is sent with the push message.

@tuxArg
Copy link

tuxArg commented Jan 25, 2025

I must have missed what's the intended way to use the UP feature. Now I have some script that detects changes and sends a dummy message to user topic when I need to force an update.
But now I notice that there is a "nextcloud extension" and that there's a way to request only some updates and not all. Is this documented somewhere? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Internal improvement of existing functions
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants