Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DB StringDefs also in DAOs and methods where they are used #1239

Closed
rfc2822 opened this issue Jan 14, 2025 · 0 comments · Fixed by #1252
Closed

Use DB StringDefs also in DAOs and methods where they are used #1239

rfc2822 opened this issue Jan 14, 2025 · 0 comments · Fixed by #1252
Assignees
@ArnyminerZ
Labels
refactoring Internal improvement of existing functions

Comments

@rfc2822
Copy link
Member

rfc2822 commented Jan 14, 2025

In #1225 we have introduced @StringDefs for database fields. We should also use them

  • in DAOs,
  • in other code where those types are used (like GetServiceCollectionPagerUseCase.invoke() – @CollectionType collectionType: String) etc
@rfc2822 rfc2822 added the refactoring Internal improvement of existing functions label Jan 14, 2025
@ArnyminerZ ArnyminerZ linked a pull request Jan 20, 2025 that will close this issue
Use DB StringDefs also in DAOs and methods where they are used #1252
Merged
4 tasks
@sunkup sunkup moved this from Todo to In Review in DAVx⁵ Releases Jan 21, 2025
@github-project-automation github-project-automation bot moved this from In Review to Done in DAVx⁵ Releases Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArnyminerZ ArnyminerZ

Labels
refactoring Internal improvement of existing functions
Projects
DAVx⁵ Releases
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use DB StringDefs also in DAOs and methods where they are used bitfireAT/davx5-ose
2 participants
@rfc2822 @ArnyminerZ