Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for sync algorithm #950

Closed
sunkup opened this issue Jul 30, 2024 · 1 comment · Fixed by #974
Closed

Tests for sync algorithm #950

sunkup opened this issue Jul 30, 2024 · 1 comment · Fixed by #974
Assignees
Labels
refactoring Internal improvement of existing functions

Comments

@sunkup
Copy link
Member

sunkup commented Jul 30, 2024

The sync algorithm is prone to be refactored again soon, but we should still write 2-5 (simple if possible) tests for the sync algorithm in abstract Syncer.

Notes:

  • If needed, make "sync()" internal/protected and "VisibleForTesting"
  • It may be nice to divide the sync algorithm further into 4 methods, which can be tested individually

The tests should ideally cover:

  • local collection delete - when remote collection is gone
  • local collection update - when remote collection has changed
  • local collection creation -when new remote collection was found
  • sync of a local collections contents (local resource) - when (number of) collection entries changed

Depends on #896

@sunkup sunkup added the refactoring Internal improvement of existing functions label Jul 30, 2024
@sunkup sunkup self-assigned this Jul 30, 2024
@sunkup sunkup mentioned this issue Jul 30, 2024
4 tasks
@sunkup sunkup mentioned this issue Jul 30, 2024
6 tasks
@github-actions github-actions bot removed the dependent label Aug 7, 2024
Copy link

github-actions bot commented Aug 7, 2024

This PR/issue depends on:

@sunkup sunkup moved this from Todo to In Progress in DAVx⁵ Releases Aug 12, 2024
@sunkup sunkup linked a pull request Aug 13, 2024 that will close this issue
4 tasks
@sunkup sunkup moved this from In Progress to In Review in DAVx⁵ Releases Aug 15, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in DAVx⁵ Releases Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Internal improvement of existing functions
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant