-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/airflow] Add dag volume mounts to web deployment for configmap-based dags #31620
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Brian Carlson <[email protected]>
Signed-off-by: Brian Carlson <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for contributing
Hi @TheRobotCarlson , We needed to apply this change to make it work with our tests. Could you please rebase it? Also, you would need to add the syncDags sidecar container. |
Hi @dgomezleon, I've rebased. The sync-dags init container isn't needed for configmap-based deployments, is it? Since it is responsible for syncing git repos and not configmaps? |
Correct, but you're adding a generic solution that should be valid for both obtaining DAGs from an existing ConfigMaps OR cloning a repository with them. |
@juan131 Does this mean the git-based DAG loading flow is not being tested at all? This would mean neither configmap-based or git-based DAG flows are working from the default deployment. I have been testing configmap-based deployments and don't have a git-based deployment flow to test from currently. |
Signed-off-by: Brian Carlson <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Description of the change
When using configmap-based DAGs, the DAGs are not linked to the webapp correctly, leading to them not being properly loaded in the UI. This PR adds them and the init containers that sync them to the necessary volume and volume locations.
Benefits
Possible drawbacks
Applicable issues
Additional information
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm