-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support specifying browsers in the local.browsers api #58
Comments
Yeah, LAUNCHPAD_BROWSERS is a working workaround, but it's an extra unnecessary step for wct users, since the wct configuration file already has a property for specifying the browsers: |
I would recommend changing the wct tests to use that configuration in |
That's a good idea. detect should only use |
Adding an optional function parameter to specify which browsers to return would fix the following issue (causing slow test ultimately in web-component-tester):
https://github.com/Polymer/wct-local/issues/21
A comment in the issue explains more clearly the cause of the issue:
https://github.com/Polymer/wct-local/issues/21#issuecomment-174602321
The parameter should be added here:
https://github.com/ekryski/launchpad/blob/master/lib/local/index.js#L59
This is just a quick proposal, I'm open to alternative solutions :).
The text was updated successfully, but these errors were encountered: