Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testee does not exit if using a config #198

Open
tracer99 opened this issue Nov 21, 2019 · 4 comments
Open

testee does not exit if using a config #198

tracer99 opened this issue Nov 21, 2019 · 4 comments

Comments

@tracer99
Copy link

tracer99 commented Nov 21, 2019

On all of our projects that are now on CanJS5/DoneJS3 testee no longer exits on completion of tests.

I've setup a bone stock donejs3 app with the only modification being the use of a config file for tests. The single tests completes successfully but testee does not exit.

https://github.com/tracer99/testee-exit

Platforms tested:
NodeJS 8 through 12
Debian Stable & old-stable
WSL & WSL2 (Debian Stable)
OSX

Note: The tests for testee itself exhibit this exact issue.

@cherifGsoul
Copy link

cherifGsoul commented Nov 27, 2019

This happens when Chrome is closed but there's a google-chrome process still hangs in the background when some extensions need to be run even if Chrome is closed.

The fix should be done on launchpad by:

  • Disable installed extensions and other services in default args
  • Use separate Chrome profile for each launch
  • Make a cleanup after killing each Chrome instance

Running the tests after killing all the running background instances closes the running instance.

@tracer99
Copy link
Author

hah. so this prompted me to look at more chrome command line switches. --bwsi seems to do the trick.

"Indicates that the browser is in "browse without sign-in" (Guest session) mode. Should completely disable extensions, sync and bookmarks. " from https://peter.sh/experiments/chromium-command-line-switches/

@tracer99
Copy link
Author

tracer99 commented Feb 5, 2020

Sadly, this stopped working. I have no idea what changes but --bwsi does nothing now.

Note this happens for Firefox as well. The only way I can have the tests run and exit properly is by not passing in any arguments. Then it work every time.

@cherifGsoul
Copy link

@tracer99 you can add clean options to make sure browser will exit:

"browsers": [
        {
            "clean": true,
            "browser": "chrome",
            "args": [
                "--headless"
            ]
        }
    ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants