Formatter over indents when slash (new line continuation) is nested

[maciejmatczak]

Hi there! The auto save format that just appeared in my .tcl files is like an additional gift from last Christmas ;). Thanks!

To the issue:

proc myProc {a b} {
    ns::setSomething \
        [differentNs::verLongCommandHenceMultilined \
            "very long input argument"]
}

For me this is a well formatted TCL code, not sure if I introduce some not needed characters. I am dealing with long named, nested invocation and sometimes try to rescue readability with new line continuation.

Formatter is not able to understand it and it results as:

proc myProc {a b} {
    ns::setSomething \
        [differentNs::verLongCommandHenceMultilined \
            "very long input argument"]
    }

Last bracket over indented. Seems related to nested square brackets eval and line continuation also there, as this:

proc myProc {a b} {
    ns::setSomething \
        [differentNs::verLongCommandHenceMultilined "very long input argument"]
}

... works fine. If you could initially guide me, do you have some tests coverage for formatting? I should be able to work on some PR if something would be already existing. Other than that, I have 0 experience in creating VSCode plugins.

[maciejmatczak]

vscode-tcl/src/formatProvider.ts

Line 46 in 5148b94

let continuation = false;

is a boolean. So we do not support any nesting there, right?

For that we would need to have continuation to have levels like indentation, am I right?

[bitwisecook]

@maciejmatczak yes, I'd be happy to receive pull requests for this