Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse multiline values #343

Closed
jonmagic opened this issue Apr 24, 2018 · 6 comments
Closed

Parse multiline values #343

jonmagic opened this issue Apr 24, 2018 · 6 comments

Comments

@jonmagic
Copy link
Collaborator

@joelvh tonight I had to revert #318 and #329 as #318 introduced a parsing regression (#336, #339, #341). We would be happy to review a follow up PR that re-introduces the feature and passes the regression tests I added in b023c9b and 294ab7b and maybe adds a few more tests.

@joelvh
Copy link
Contributor

joelvh commented Apr 25, 2018

@jonmagic looks like a test is missing for #339, which is not a commented line, but a variable with no value. I've created #344 to add the test until I've got a solution for these regressions. Will report back when I've got something!

@joelvh
Copy link
Contributor

joelvh commented May 7, 2018

@jonmagic #346 fixed regressions that were reported in v2.3.0

@sufyanadam
Copy link

@jonmagic would be good to get #346 merged. I have a configuration that's hard to maintain on a single line with \n.

@sufyanadam
Copy link

Thanks for getting this in @cadwallion :)

I'm using a fork of the project with this included. I will switch back to the original once a new release is pushed out.

@cadwallion
Copy link
Collaborator

Version 2.5.0 was just released, sorry for the wait!

@joelvh
Copy link
Contributor

joelvh commented Jun 21, 2018

Thanks @cadwallion !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants