Support for Multiple Teams #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API key parameters (key path, key id, issuer id) are now stored in user defaults instead of retrieved from the environment. This enables the registration of one App Store Connect API key for each of your teams and loosens the rstriction to only one API key. All ASC commands can now operate on all teams if desired. Alternatively each command can ask for which team the action should be performed.
Blackjacx
force-pushed
the
api-key-registration
branch
from
de1d8cd to
1a6fd32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Support for multiple teams
The basics of supporting the registration of multiple teams enables us to support multiple teams too. Now, whenever you have more than one key registered, the tool asks you which one you want to use. With this you can operate on multiple teams.
Implement API key registration (no env variables anymore)
API key parameters (key path, key id, issuer id) are now stored in
user defaults instead of retrieved from the environment.
This enables the registration of one App Store Connect API key for
each of your teams and loosens the rstriction to only one API key.
All ASC commands can now operate on all teams if desired.
Alternatively each command can ask for which team the action
should be performed.
Usage of operations and operation queues
Subcommand
api-keysuses operations under the hood wich will also be the new standard in future. Next big step is to remove the huge enum class and create nice little operation classes for each. Implementation of the command pattern is coming 🎉Issues