Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check library import after Pypi upload #225

Closed
rlouf opened this issue Jun 16, 2022 · 6 comments · Fixed by #295
Closed

Check library import after Pypi upload #225

rlouf opened this issue Jun 16, 2022 · 6 comments · Fixed by #295
Milestone

Comments

@rlouf
Copy link
Member

rlouf commented Jun 16, 2022

Should allow us catch issues such as #223.

@thomaspinder
Copy link

Hey @rlouf

I've pinned BlackJax version 0.8.2 in GPJax, but we're still getting import errors similar to those in #223. Any ideas how this can be resolved?

https://gpjax--79.org.readthedocs.build/en/79/nbs/classification.html

@junpenglao
Copy link
Member

@thomaspinder Could you add jaxopt to your dependence? Sorry about breaking your side!

@thomaspinder
Copy link

Thanks! That seems to have fixed it.

Is there any view to adding jaxopt to the dependencies of BlackJax?

@rlouf
Copy link
Member Author

rlouf commented Jun 16, 2022

Yes this was raised in #212. We're ready to include jax, jaxlib and jaxopt as dependencies now.

@rlouf
Copy link
Member Author

rlouf commented Jun 27, 2022

PyMC checks that the package has been uploaded. We can run python -c "import blackjax" afterwards.

@rlouf rlouf added this to the 1.0 milestone Jun 29, 2022
@rlouf
Copy link
Member Author

rlouf commented Sep 19, 2022

The current test fails:

ERROR: Could not find a version that satisfies the requirement blackjax==.8.3 (from versions: 0.1, 0.2, 0.2.1, 0.3.0, 0.4.0, 0.5.0, 0.6.0, 0.7.0, 0.8.0, 0.8.1, 0.8.2, 0.8.3)
ERROR: No matching distribution found for blackjax==.8.3

the reason being that blackjax==${GITHUB_REF:11} should be replaced with blackjax==${GITHUB_REF:10}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants