Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple the schedule_fn from the step function in high-level SgMCMC algorithm #347

Closed
rlouf opened this issue Sep 24, 2022 · 0 comments · Fixed by #299
Closed

Decouple the schedule_fn from the step function in high-level SgMCMC algorithm #347

rlouf opened this issue Sep 24, 2022 · 0 comments · Fixed by #299
Labels
enhancement New feature or request refactoring Change that adds no functionality but improves code quality

Comments

@rlouf
Copy link
Member

rlouf commented Sep 24, 2022 •
edited
Loading

Knowledge of the current iteration is made necessary by the use of schedule_fn at the highest level. It shouldn't therefore be propagated down to the algorithms and add stop extra logic there for step counting.

I think we should take one step further and remove support for schedule_fn altogether in the high-level interface. It complicated the library a little, and having used SGMCMC for #209 I don't see any use for it.
@rlouf rlouf added enhancement New feature or request refactoring Change that adds no functionality but improves code quality labels Sep 24, 2022
@rlouf rlouf changed the title Factor the step number out of SgMCMC algorithms Decouple the schedule from the step function in high-level SgMCMC algorithm Oct 4, 2022
@rlouf rlouf changed the title Decouple the schedule from the step function in high-level SgMCMC algorithm Decouple the schedule_fn from the step function in high-level SgMCMC algorithm Oct 4, 2022
@rlouf rlouf linked a pull request Nov 27, 2022 that will close this issue
Add the control variates gradient estimator #299
Merged
@rlouf rlouf closed this as completed Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request refactoring Change that adds no functionality but improves code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add the control variates gradient estimator rlouf/blackjax
1 participant
@rlouf