Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MCMCSamplingAlgorithm -> SamplingAlgorithm #541

Closed
albcab opened this issue Jun 1, 2023 · 0 comments · Fixed by #542
Closed

MCMCSamplingAlgorithm -> SamplingAlgorithm #541

albcab opened this issue Jun 1, 2023 · 0 comments · Fixed by #542

Comments

@albcab
Copy link
Member

albcab commented Jun 1, 2023

#392 changed SamplingAlgorithm to MCMCSamplingAlgorithm. This class now includes other non-MCMC sampling algorithms, i.e. particle methods such as SMC and soon SVGD.

I propose to change MCMCSamplingAlgorithm back to SamplingAlgorithm to encompass a more general class of algorithms.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MCMCSamplingAlgorithm -> SamplingAlgorithm albcab/blackjax
1 participant
@albcab