Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing high-level API classes #659

Closed
ciguaran opened this issue Apr 18, 2024 · 4 comments
Closed

Removing high-level API classes #659

ciguaran opened this issue Apr 18, 2024 · 4 comments

Comments

@ciguaran
Copy link
Contributor

This is a continuation of:

#492

#501

See two solution alternatives
#657 replacing classes with objects of a single class
#658 replacing classes with functions

@reubenharry
Copy link
Contributor

Thanks for looking into this! I tend to favour the more functional solution (#658)

@junpenglao
Copy link
Member

Thank you for working on this!! This is a great suggest and i like the solutions!

So IIUC: #657 add the object to create high-level alias on top of the functional solution in #658.
While I also like #658 better, for backward compatibility we should go with #657. It should be easy to migrate/deprecate the object in the future because it is just one Python object and everything will be in the single file.

@albcab
Copy link
Member

albcab commented Apr 19, 2024

+1 what Junpeng said since #658 would break any script using blackjax

@junpenglao
Copy link
Member

Fixed in #657

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants