Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicates #1

Open
DragonsWho opened this issue May 26, 2024 · 4 comments
Open

Duplicates #1

DragonsWho opened this issue May 26, 2024 · 4 comments

Comments

@DragonsWho
Copy link

The program finds the same IDs, but does not respond to the same Choices names. This is not a critical error or anything, but it would be better if it would flag it.

@blathers16
Copy link
Owner

Are you saying that it finds duplicate IDs with different choice names? Are these IDs duplicates with different Choice names, or is this a mistaken finding? If these are actual duplicate IDs, what change are you suggesting? It seems appropriate to flag them to me if the IDs are duplicates, even if the choice names are different, as that may or may not be intentional.

@DragonsWho
Copy link
Author

I mean, there can be two choices with different IDs but the same name. Yes, this can be done on purpose..... But it could also be a mistake >_>

So it's worth noting. Maybe not in the scary red color, but in yellow, like a minor remark or something.

It's just that I'm renaming all the IDs to make the player builds more readable, so there was no error at first, and then it appeared, otherwise I wouldn't have even noticed that I have two choices named exactly the same >_>

@DragonsWho
Copy link
Author

DragonsWho commented May 27, 2024

image
By the way, the error message occurs even when there are no more such errors

@blathers16
Copy link
Owner

It shouldn't show 2 choices with the same name but different IDs as duplicates. The other thing is a bug, that I need to find the time to look at.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants