-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dalena integration #66
Conversation
…hes, added diagram to background, sound on!
@blerchin @brysonian Dalena is using jquery and howler for her project and these seem to increase the page size by 53KB. Would this be a cause for issues? Although I highly doubt it I was wondering if there's a way to deliver these only on her page. |
@hsab this doesn't answer your question, but it looks like the jquery is being used very minimally and could be replaced with vanilla js. I think it makes sense to keep the howler. |
It's possible to only deliver jquery on Dalena's page with webpack chunk splitting. But personally I'd prefer to spend that time removing jquery altogether. As Lauren mentioned it is used minimally – mostly for element lookups, which can be replaced with |
@dalena I modified this to remove all the jquery uses. I can see why you weren't excited about doing that, but ultimately everything it was doing could be replaced by <3 lines of js + CSS. |
c51e58a
to
c19650f
Compare
Well, it's almost working. For some reason switching from jQuery.async to fetch is causing the dreaded Navigation TimeoutError in |
@blerchin looks great! Thanks for spending and hour or so on this. 🙏🏼🌹 |
@blerchin I get the following from netlify |
@hsab huh, seems like a weird Netlify fluke |
@blerchin thank you so much for doing that. Everything seems to still be functioning! I'm okay with this if there is no more issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay! Looks good to me
So, phew... with the extensive help of @hsab and @brysonian I was able to get my project files integrated onto the site. Tried to make sure that there aren't any conflicts with the rest if the site. @blerchin @lmccart @brysonian have a look to see if there are any issues that come up from your end.
I'm hoping to get my mp3 files hosted somewhere more reliable than github pages/github releases, but that's where my audio files are hosted as of now. I am still preparing my voiceover audio and will make some minor changes to my files before launching. Other than that, it should be complete!