Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphMap support in transform #76

Open
dmyyy opened this issue Sep 3, 2023 · 4 comments
Open

GraphMap support in transform #76

dmyyy opened this issue Sep 3, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@dmyyy
Copy link
Contributor

dmyyy commented Sep 3, 2023

I'm using GraphMap so this would be useful for me. Could make sense to add a Transformable trait, or even better impl Into<Graph<N, E, Ty>> for GraphMap<N, E, Ty>. Not sure I understand the use case for to_input_graph_custom.

@blitzarx1
Copy link
Owner

Good idea. I ll take a look into it on the upcoming week. If you wish you can file a PR as well.

You can check the usage of to_input_graph_custom in the examples. But I agree that variant with trait implementation would be more seamless and straightforward integration for users of the lib.

@blitzarx1 blitzarx1 self-assigned this Sep 3, 2023
@blitzarx1 blitzarx1 added the enhancement New feature or request label Sep 3, 2023
@blitzarx1
Copy link
Owner

Sorry for long response. I ve recently added From support for new public API type Graph. It support petgraph::StableGraph conversion to Graph type. #77

In the following PRs I will also support GraphMap as we discussed here.

@blitzarx1
Copy link
Owner

Long time since my last visit here. @dmyyy if you think you can take this one as well, please go for it. I don't feel like getting this done soon. I am focused on other issues now.

@dmyyy
Copy link
Contributor Author

dmyyy commented Nov 7, 2023

If I get something working I'll put out a pr for this one as well - not my focus currently but we'll see if I get to it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants