node['bcpc']['node_number'] is not derived from cluster_def node_id

[http-418]

We have taken to setting node_id in cluster.txt, and some code relies on those node IDs. Unfortunately, those node IDs are at no point copied into node objects, so older code that relies on node[:bcpc][:node_number] will get a bogus value derived from the MAC address.

This is particularly dangerous on Zookeeper clusters, where one value is used for the zoo.cfg cluster definition, and the other value is used for the myid file.

For now we can work around this issue by copying the values in chef-shell after chef installation but before cheffing nodes:

sudo chef-shell -z -o 'bach_hadoop_wrapper'

require 'cluster_def'
BACH::ClusterDef.new.fetch_cluster_def().map { |ss| 
  nn = Chef::Node.load(ss[:fqdn])
  nn.normal[:bcpc][:node_number] = ss[:node_id]
  nn.save 
}

At some point we need to really fix this.

[pu239ppy]

This may have been an omission on my part, however it is also possible at the time of writing I mean to make sure all node number requests are serviced from the file. Perhaps I should have documented this explicitly