Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package-lock.json #1

Open
jhshi opened this issue Nov 28, 2017 · 3 comments
Open

package-lock.json #1

jhshi opened this issue Nov 28, 2017 · 3 comments

Comments

@jhshi
Copy link
Contributor

jhshi commented Nov 28, 2017

After cloning the project and make check, this file was created and is shown as "untracked files" in git. Shall this file be added to .gitignore?

@gjbunyea
Copy link
Member

I think package-lock.json is typically commited

@jhshi
Copy link
Contributor Author

jhshi commented Nov 29, 2017

From the doc that should be the case.

https://docs.npmjs.com/files/package-lock.json

But why it was not in the source tree when I clone it? I can not be the first person that generates that file.

@gchallen
Copy link
Member

Older versions of node (<8) didn't generate this file. It's safe to commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants