Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ping1d class to use official request() message #60

Open
jaxxzer opened this issue May 23, 2019 · 1 comment · May be fixed by #123
Open

Update ping1d class to use official request() message #60

jaxxzer opened this issue May 23, 2019 · 1 comment · May be fixed by #123
Milestone

Comments

@jaxxzer
Copy link
Member

jaxxzer commented May 23, 2019

No description provided.

@ES-Alexander ES-Alexander added this to the 0.2.0 milestone Dec 2, 2021
@ES-Alexander ES-Alexander linked a pull request Mar 20, 2022 that will close this issue
18 tasks
@ES-Alexander
Copy link
Contributor

Should also remove legacy request hack in pingmessage.PingMessage (self.request_id property, and its usage in pack_msg_data).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants