Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"New post" indicator (blue dot) does not work if a pinned post is present #7697

Open
vyv03354 opened this issue Feb 8, 2025 · 0 comments · May be fixed by #7716
Open

"New post" indicator (blue dot) does not work if a pinned post is present #7697

vyv03354 opened this issue Feb 8, 2025 · 0 comments · May be fixed by #7716
Labels
bug Something isn't working

Comments

@vyv03354
Copy link

vyv03354 commented Feb 8, 2025

Steps to Reproduce

Steps to reproduce:
2. Go to any user timeline that has a pinned post.
3. Scroll down until scroll-to-top button appears.
4. Wait until the user makes a new post.
Actual result:
No "new post" indicator (blue dot) appears.

Expected result:
"New post" indicator (blue dot) should appear.

Attachments

No response

What platform(s) does this occur on?

Web (Desktop)

Device Info

Windows 10 24H2 build 26100.2894

What version of the app are you using?

Build version: 1.97.0; Bundle info: 1a60481 (prod); Bundle date: 25020619; Platform: web; Platform version: undefined

Additional Information

getAuthorFeed will return two posts even with limit=1 parameter if a pinned post exists. But AuthorFeedAPI.peekLatest will always return the first element (that is, the pinned post):

social-app/src/lib/api/feed/author.ts

Lines 32 to 37 in 98b7e95

async peekLatest(): Promise<AppBskyFeedDefs.FeedViewPost> {
const res = await this.agent.getAuthorFeed({
...this.params,
limit: 1,
})
return res.data.feed[0]

So pollLatest will never detect new posts unless the pinned post changes:

social-app/src/state/queries/post-feed.ts

Lines 427 to 429 in 98b7e95

const post = await page.api.peekLatest()
if (post) {
const slices = page.tuner.tune([post], {

@vyv03354 vyv03354 added the bug Something isn't working label Feb 8, 2025
@c960657 c960657 linked a pull request Feb 10, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Exclude pins when polling author feed for updates c960657/bluesky-app
1 participant
@vyv03354