Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlighting anomalies #47

Open
mattmc3 opened this issue Mar 19, 2024 · 0 comments
Open

Syntax highlighting anomalies #47

mattmc3 opened this issue Mar 19, 2024 · 0 comments

Comments

@mattmc3
Copy link

mattmc3 commented Mar 19, 2024

I use your highlighter in VSCode and it's really helpful. Thanks for maintaining this project.

In my usage of this plugin, I've noticed some anomalies:

  • The second pipe in an or (||) is weirdly not colorized, and && isn't colorized at all.
  • commands are not properly colorized on same line ;or or ;and Fish syntax
Screenshot 2024-03-19 at 10 26 52 AM

As an aside, I'm also a long time SublimeText user, and the syntax highlights this way with the Sublime Fish plugin.

Screenshot 2024-03-19 at 10 36 26 AM

I'm not sure if VSCodes' grammars support .sublime-syntax files, or if there's a way to convert those back to TextMate grammars (which Sublime used originally), and then use that .tmLanguage grammar file to generate an updated VSCode one. That might be one way to capture some of these anomalies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant